chore: add vercel preview url step #3898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
Coverage Report
File CoverageNo changed files found. |
enesozturk
commented
Feb 24, 2025
| @@ -57,7 +57,6 @@ const SINGLE_ADAPTER_EVM_TESTS = [ | |||
| 'wallet-features.spec.ts', | |||
| 'wallet.spec.ts', | |||
| 'wallet-button.spec', | |||
| 'verify.spec.ts', | |||
There was a problem hiding this comment.
Revert Canary and Verify tests back
|
tomiir
reviewed
Feb 24, 2025
| env: | ||
| VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }} | ||
| with: | ||
| deployment-url: appkit-lab.reown.com # TODO Replace by the domain you want to test |
tomiir
reviewed
Feb 24, 2025
Comment on lines
+124
to
+133
| # Disable temporarily | ||
| # - name: Run canary with minimal environment config | ||
| # env: | ||
| # # DO NOT MODIFY THIS. If you are required to add variables here without adding | ||
| # # them to the rs-relay repo it will cause alarms. | ||
| # NEXT_PUBLIC_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_PROJECT_ID }} | ||
| # NEXTAUTH_SECRET: ${{ secrets.TESTS_NEXTAUTH_SECRET }} | ||
| # CI: true | ||
| # working-directory: ./apps/laboratory/ | ||
| # run: pnpm playwright:test:canary |
tomiir
reviewed
Feb 24, 2025
Comment on lines
+368
to
+374
| await this.page.waitForTimeout(500) | ||
| } | ||
|
|
||
| async approveSign() { | ||
| await this.signatureRequestFrameShouldVisible('requests a signature') | ||
| await this.clickSignatureRequestButton('Sign') | ||
| await this.page.waitForTimeout(1000) |
There was a problem hiding this comment.
do we still need these timeouts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
~12min cut from our GitHub E2E workflows: Added Vercel preview step to our workflow; it does await the Vercel preview to be built, then get the preview URL and uses it for the E2E tests
5 shard x lab build (around 2.40m) = around 12minType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist